Skip to content

Navigation Menu

Appearance settings

GitHub Copilot
Write better code with AI

GitHub Spark New
Build and deploy intelligent apps

GitHub Models New
Manage and compare prompts

GitHub Advanced Security
Find and fix vulnerabilities

Actions
Automate any workflow
Codespaces
Instant dev environments

Issues
Plan and track work

Code Review
Manage code changes

Discussions
Collaborate outside of code

Code Search
Find more, search less
Explore

Why GitHub

Documentation

GitHub Skills

Blog
Integrations

GitHub Marketplace

MCP Registry
View all features
By company size

Enterprises

Small and medium teams

Startups

Nonprofits
By use case

App Modernization

DevSecOps

DevOps

CI/CD

View all use cases
By industry

Healthcare

Financial services

Manufacturing

Government

View all industries
View all solutions
Topics

AI

DevOps

Security

Software Development

View all
Explore

Learning Pathways

Events & Webinars

Ebooks & Whitepapers

Customer Stories

Partners

Executive Insights
GitHub Sponsors
Fund open source developers
The ReadME Project
GitHub community articles
Repositories

Topics

Trending

Collections
Enterprise platform
AI-powered developer platform
Available add-ons

GitHub Advanced Security
Enterprise-grade security features

Copilot for business
Enterprise-grade AI features

Premium Support
Enterprise-grade 24/7 support
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

Appearance settings

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

mongodb-js / compass Public

Notifications You must be signed in to change notification settings
Fork 245
Star 1.4k

Code
Pull requests 33
Actions
Wiki
Security
Insights

Additional navigation options

Code
Pull requests
Actions
Wiki
Security
Insights

feat: error details on update COMPASS-8865 #6778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

paula-stacho merged 14 commits into validation-errors from COMPASS-8865-2

Mar 19, 2025

Merged

feat: error details on update COMPASS-8865 #6778

paula-stacho merged 14 commits into validation-errors from COMPASS-8865-2

Mar 19, 2025

Conversation 13 Commits 14 Checks 2 Files changed

Uh oh!

There was an error while loading. Please reload this page.

Conversation

Copy link

Collaborator

paula-stacho commented Mar 6, 2025 •

edited

Loading

Description

Continuing the error details, this time for single update (3 modes). E2E tests added.

Checklist

New tests and/or benchmarks are included
Documentation is changed or added
I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

Bugfix
New feature
Dependency update
Misc

Open Questions

Dependents

Types of changes

Backport Needed
Patch (non-breaking change which fixes an issue)
Minor (non-breaking change which adds functionality)
Major (fix or feature that would cause existing functionality to change)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

github-actions bot added the feat label

paula-stacho added the no release notes Fix or feature not for release notes label

paula-stacho marked this pull request as ready for review

March 10, 2025 08:55

gribnoysup reviewed

View reviewed changes

packages/compass-components/src/components/document-list/document-edit-actions-footer.tsx Outdated Show resolved Hide resolved

Uh oh!

There was an error while loading. Please reload this page.

paula-stacho force-pushed the validation-errors branch from 9ac047e to b574c1e Compare

March 14, 2025 10:06

gribnoysup reviewed

View reviewed changes

packages/compass-e2e-tests/tests/collection-documents-tab.test.ts Outdated Show resolved Hide resolved

Uh oh!

There was an error while loading. Please reload this page.

gribnoysup reviewed

View reviewed changes

packages/compass-e2e-tests/tests/collection-documents-tab.test.ts Outdated Show resolved Hide resolved

Uh oh!

There was an error while loading. Please reload this page.

gribnoysup reviewed

View reviewed changes

packages/compass-e2e-tests/tests/collection-documents-tab.test.ts Outdated Show resolved Hide resolved

Uh oh!

There was an error while loading. Please reload this page.

gribnoysup reviewed

View reviewed changes

packages/compass-crud/src/components/document-list.tsx Outdated Show resolved Hide resolved

Uh oh!

There was an error while loading. Please reload this page.

paula-stacho added 6 commits

March 17, 2025 10:40

wip

80f1ece


          feat: error details on update COMPASS-8865

9f2d23b


          add tests

9ec2f20


          styling

a16eaba


          cleanup

d872d61


          fix type

7375b3d

paula-stacho force-pushed the COMPASS-8865-2 branch from a9291df to 7375b3d Compare

March 17, 2025 09:43

paula-stacho added 6 commits

March 17, 2025 16:25


          refactor: hook

03fdfe7


          do not use the event with the hook

80af7bb


          cleanup

6bfc571

wip

9ae12db


          update tests

154575e


          cleanup and fix the non-react path

b0944f7

paula-stacho force-pushed the COMPASS-8865-2 branch from c8bdd3f to b0944f7 Compare

March 18, 2025 12:41


          cleanup hook

1ac104e

gribnoysup approved these changes

View reviewed changes

packages/compass-crud/src/components/document-list.tsx Outdated

    
                spacing,

                withDarkMode,

                ErrorDetailsModal,

                ErrorDetailsModalArea,

Copy link

Collaborator

gribnoysup Mar 19, 2025

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leftover?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

paula-stacho reacted with eyes emoji

All reactions

👀 1 reaction

packages/compass-crud/src/components/table-view/full-width-cell-renderer.tsx Outdated

    
              import {

                ConfirmationModalArea,

                DocumentList,

                ErrorDetailsModalArea,

Copy link

Collaborator

gribnoysup Mar 19, 2025

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leftover?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

paula-stacho reacted with eyes emoji

All reactions

👀 1 reaction

Copy link

Collaborator Author

paula-stacho Mar 19, 2025

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, thanks for noticing!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          cleanup

afe8fab

paula-stacho merged commit f6402c1 into validation-errors

2 checks passed

Uh oh!

There was an error while loading. Please reload this page.

paula-stacho deleted the COMPASS-8865-2 branch

March 19, 2025 13:39

paula-stacho added a commit that referenced this pull request


          feat: error details on update COMPASS-8865 (#6778)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gribnoysup gribnoysup approved these changes

Assignees

No one assigned

Labels

feat no release notes

Fix or feature not for release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Community
Docs
Contact

You can’t perform that action at this time.