Skip to content

Conversation

@paula-stacho
Copy link
Collaborator

@paula-stacho paula-stacho commented Mar 13, 2025

Description

What we're trying to solve:
When the download is handed over to the browser, a full-fledged browser will show the download progress and success/failure + link to the file.
Example: chrome
Screenshot 2025-03-13 at 17 03 33

Desktop electron doesn't have this, and it feels weird when you click save and nothing happens. So we're adding a minimalistic solution to for browser download success/failure, by listening to the session's will-download - see electron docs.

  • The messaging is generic, because the solution is generic.
  • Error message is unfortunately not available.
  • No progress, because it's a bit trickier, the schema export is pretty quick, and we didn't want to spend much time on this. Can be a follow up.

Screenshot 2025-03-13 at 16 15 11.

Note: if you want to reproduce the failure, try saving the file into a read-only folder.

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added
  • If this change updates the UI, screenshots/videos are added and a design review is requested
  • I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@github-actions github-actions bot added the feat label Mar 13, 2025
@paula-stacho paula-stacho added the feature flagged PRs labeled with this label will not be included in the release notes of the next release label Mar 13, 2025
Copy link
Member

@Anemy Anemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@paula-stacho paula-stacho merged commit d9b1735 into main Mar 14, 2025
69 of 71 checks passed
@paula-stacho paula-stacho deleted the COMPASS-9095 branch March 14, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat feature flagged PRs labeled with this label will not be included in the release notes of the next release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants