Skip to content

Conversation

@gribnoysup
Copy link
Collaborator

We're 2 majors behind for eslint and 1 major for prettier, before we start updating those I want to remove the need to update those everywhere. We did a similar thing for webpack some time ago and it made it way easier to maintain the version, so copying the approach for prettier and eslint:

  • add bin exports for local prettier config and eslint config that alias those tools with a few small additions to make usage consistent
  • remove prettier and eslint from dependencies everywhere except for the config packages
  • remove duplicated prettier configs and ignores, those are pulled by the new bin automatically
    • specifically for ignores I left the ones that are notceably different from the default one

@gribnoysup gribnoysup added the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label Mar 27, 2025
Copy link
Contributor

@lerouxb lerouxb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new precommit doesn't skip some of the root files anymore that it was missing before (hence the massive diff) and I think that before this was happening by mistake, so I'm not planning to restore this behavior in the new precommit hook code. This got updated because I did a merge from main to resolve a conflict

@gribnoysup gribnoysup merged commit e1ead85 into main Mar 27, 2025
48 of 51 checks passed
@gribnoysup gribnoysup deleted the re-export-eslint-prettier-bin branch March 27, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants