Skip to content

fix(compass-crud): no 0 default for bulkDelete count COMPASS-8603 #6840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2025
Merged

fix(compass-crud): no 0 default for bulkDelete count COMPASS-8603 #6840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50bc34a
fix(compass-crud): do not use 0 as default for bulkDelete count COMPA…
paula-stacho Apr 4, 2025
3986b11
test: update tests
paula-stacho Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/compass-crud/src/stores/crud-store.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ describe('store', function () {
debouncingLoad: false,
loadingCount: false,
collection: 'test',
count: 0,
count: null,
docs: [],
docsPerPage: 25,
end: 0,
Expand Down Expand Up @@ -1170,6 +1170,7 @@ describe('store', function () {
store.state.insert.jsonView = true;
store.state.insert.doc = hadronDoc;
store.state.insert.jsonDoc = jsonDoc;
store.state.count = 0;
});

it('does not insert the document and sets the error', async function () {
Expand Down Expand Up @@ -1202,6 +1203,7 @@ describe('store', function () {
store.state.insert.jsonView = true;
store.state.insert.doc = hadronDoc;
store.state.insert.jsonDoc = jsonDoc;
store.state.count = 0;
});

afterEach(function () {
Expand Down Expand Up @@ -1233,6 +1235,7 @@ describe('store', function () {
beforeEach(function () {
store.state.insert.doc = doc;
store.state.insert.jsonDoc = jsonDoc;
store.state.count = 0;
});

afterEach(function () {
Expand Down Expand Up @@ -1267,6 +1270,7 @@ describe('store', function () {
store.state.insert.jsonView = true;
store.state.insert.doc = hadronDoc;
store.state.insert.jsonDoc = jsonDoc;
store.state.count = 0;
});

afterEach(async function () {
Expand Down Expand Up @@ -1425,6 +1429,7 @@ describe('store', function () {

beforeEach(function () {
store.state.insert.jsonDoc = JSON.stringify(docs);
store.state.count = 0;
});

afterEach(function () {
Expand Down
4 changes: 2 additions & 2 deletions packages/compass-crud/src/stores/crud-store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,7 +426,7 @@ class CrudStoreImpl
end: 0,
page: 0,
view: LIST,
count: 0,
count: null,
insert: this.getInitialInsertState(),
bulkUpdate: this.getInitialBulkUpdateState(),
bulkDelete: this.getInitialBulkDeleteState(),
Expand Down Expand Up @@ -1913,7 +1913,7 @@ class CrudStoreImpl

const confirmation = await showConfirmation({
title: 'Are you absolutely sure?',
buttonText: `Delete ${affected || 0} document${
buttonText: `Delete ${affected ? `${affected} ` : ''} document${
affected !== 1 ? 's' : ''
}`,
description: `This action can not be undone. This will permanently delete ${
Expand Down
Loading