Skip to content

fix(compass-indexes): fix tooltip triggers in indexes plugin COMPASS-8449 #6844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025
Merged

fix(compass-indexes): fix tooltip triggers in indexes plugin COMPASS-8449 #6844

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion packages/compass-indexes/src/components/regular-indexes-table/property-field.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,16 @@ const PropertyBadgeWithTooltip: React.FunctionComponent<{
return (
<Tooltip
enabled={!!tooltip}
trigger={<BadgeWithIconLink link={link} text={text} />}
trigger={({
children: tooltipChildren,
...tooltipTriggerProps
}: React.HTMLProps<HTMLDivElement>) => (
<div {...tooltipTriggerProps}>
<BadgeWithIconLink link={link} text={text} />
{tooltipChildren}
</div>
)}
triggerEvent="hover"
>
<Body>{tooltip}</Body>
</Tooltip>
Expand Down
16 changes: 11 additions & 5 deletions packages/compass-indexes/src/components/regular-indexes-table/status-field.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,17 @@ const BadgeWithTooltip: React.FunctionComponent<{
<Tooltip
enabled={!!tooltip}
darkMode={darkMode}
trigger={
<Badge data-testid={dataTestId} variant={variant}>
{children}
</Badge>
}
trigger={({
children: tooltipChildren,
...tooltipTriggerProps
}: React.HTMLProps<HTMLDivElement>) => (
<div {...tooltipTriggerProps}>
<Badge data-testid={dataTestId} variant={variant}>
{children}
</Badge>
{tooltipChildren}
</div>
)}
>
<Body>{tooltip}</Body>
</Tooltip>
Expand Down
12 changes: 9 additions & 3 deletions packages/compass-indexes/src/components/regular-indexes-table/type-field.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,15 @@ const TypeField: React.FunctionComponent<TypeFieldProps> = ({
return (
<Tooltip
enabled={canRenderTooltip(type)}
trigger={
<BadgeWithIconLink text={type ?? 'unknown'} link={link ?? '#'} />
}
trigger={({
children: tooltipChildren,
...tooltipTriggerProps
}: React.HTMLProps<HTMLDivElement>) => (
<div {...tooltipTriggerProps}>
<BadgeWithIconLink text={type ?? 'unknown'} link={link ?? '#'} />
{tooltipChildren}
</div>
)}
>
{extra && <IndexTypeTooltip extra={extra} />}
</Tooltip>
Expand Down
12 changes: 9 additions & 3 deletions packages/compass-indexes/src/components/search-indexes-table/search-indexes-table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,9 +148,15 @@ function VectorSearchIndexDetails({ definition }: { definition: Document }) {
align="top"
key={field.path}
justify="middle"
trigger={
<Badge className={searchIndexFieldStyles}>{field.path}</Badge>
}
trigger={({
children: tooltipChildren,
...tooltipTriggerProps
}: React.HTMLProps<HTMLDivElement>) => (
<div {...tooltipTriggerProps}>
<Badge className={searchIndexFieldStyles}>{field.path}</Badge>
{tooltipChildren}
</div>
)}
>
{JSON.stringify(field, null, 2)}
</Tooltip>
Expand Down
Loading