fix(shell): prevent horizontal overflow scroll COMPASS-9418 #6978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribnoysup
approved these changes
Jun 2, 2025
Collaborator
gribnoysup
left a comment
gribnoysup
left a comment
There was a problem hiding this comment.
Nice catch, I tried various scenarios (and found a unrelated bug 🙈) and this seems to work for me just fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMPASS-9418
Likely a leftover from when the shell was the full width at the bottom of the window.
Now it shouldn't overflow in a way that prevents user interaction.
It would be nice if the reviewer tries it out to see if there are any situations I might be missing. Try inputting a lot of text and scrolling, multi-line, etc in the embedded shell area. To me it's looking good but I might be missing a corner case. Doesn't seem like something we can easily test besides manually.