chore(data-modeling): update drawer icon label to be generic #7356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anemy
requested review from
Copilot and
mabaasit
and removed request for
Copilot
Anemy
added
feature flagged
|
Assigned |
gribnoysup
reviewed
Sep 23, 2025
packages/compass-data-modeling/src/components/drawer/diagram-editor-side-panel.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull Request Overview
Updates the drawer panel in the data modeling component to show generic configuration labels instead of displaying the specific item names. This improves the UI by providing clearer context about what type of configuration is being edited.
- Changes drawer title structure to separate item title from configuration type label
- Updates property naming from
labeltotitlefor better semantic clarity - Adds generic labels like "Collection Configuration", "Relationship Configuration", and "Field Configuration"
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/compass-data-modeling/src/components/drawer/diagram-editor-side-panel.tsx | Updates drawer component to use generic configuration labels and separates title from label properties |
| packages/compass-data-modeling/src/utils/nodes-and-edges.tsx | Changes div element to italic element for mixed type display |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
packages/compass-data-modeling/src/components/drawer/diagram-editor-side-panel.tsx
Show resolved
Hide resolved
Anemy
commented
Sep 23, 2025
| } | ||
| > | ||
| <div>(mixed)</div> | ||
| <i>(mixed)</i> |
gribnoysup
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ben mentioned this sometime back in a design review.