Skip to content

Conversation

@gribnoysup
Copy link
Collaborator

Based on this scope discussion, trying out relationships inference with some of the sample data sets, and a recent discussion with product, we want to make the inference algorithm slightly more forgiving for one specific case: when _id field is of type ObjectId, we can be pretty confident that we're looking at a real relationship if even a single matching document is found, so instead of looking for an exact match with sample documents count, we will look for at least one matching doc.

@gribnoysup gribnoysup requested a review from a team as a code owner October 22, 2025 14:25
@gribnoysup gribnoysup added the feature flagged PRs labeled with this label will not be included in the release notes of the next release label Oct 22, 2025
@gribnoysup gribnoysup requested a review from lerouxb October 22, 2025 14:25
@gribnoysup gribnoysup added the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label Oct 22, 2025
@github-actions github-actions bot added the feat label Oct 22, 2025
@gribnoysup gribnoysup merged commit 4df3357 into main Oct 22, 2025
60 of 61 checks passed
@gribnoysup gribnoysup deleted the allow-partial-match-for-object-id-id-field-when-inferring-relations branch October 22, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat feature flagged PRs labeled with this label will not be included in the release notes of the next release no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants