Skip to content

Conversation

@paula-stacho
Copy link
Collaborator

@paula-stacho paula-stacho commented Oct 23, 2025

Description

For some reason 2 of the collection rename tests keep failing in the CI. I can't reproduce it locally. From the screenshot it seems the screen is smaller and numbers collection is near the bottom of the viewport. So my hunch is that even though it's not captured on the screenshot, there was a toast over that item before.

https://spruce.mongodb.com/task/10gen_compass_testing_test_packaged_app_macos_14_arm_test_packaged_app_2_944d8153f7db55d2b42fd00b7195afc851c34d87_25_10_23_15_38_13/tests?execution=3&sorts=STATUS%3AASC

@paula-stacho paula-stacho requested a review from a team as a code owner October 23, 2025 20:55
@paula-stacho paula-stacho requested review from Copilot and ivandevp and removed request for Copilot October 23, 2025 20:55
@paula-stacho paula-stacho added no release notes Fix or feature not for release notes no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) labels Oct 23, 2025
Copilot AI review requested due to automatic review settings October 23, 2025 21:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses flaky E2E tests for collection renaming by changing the test collection from 'numbers' to 'csv-file'. The change aims to avoid potential toast notification overlays that may have been interfering with test interactions when 'numbers' appeared near the bottom of the viewport in CI environments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Collaborator

@gribnoysup gribnoysup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're sure it's a toast, we can check for toasts before proceeding, this would be more stable than relying on a position of a different collection again, I'm afraid this can degrade again because we're not resolving the root cause here.

I'm fine if you want to merge this as a quick fix, but would be nice to follow-up

@paula-stacho paula-stacho merged commit 04336ad into main Oct 24, 2025
173 of 182 checks passed
@paula-stacho paula-stacho deleted the update-rename-test branch October 24, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no release notes Fix or feature not for release notes no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants