-
Notifications
You must be signed in to change notification settings - Fork 247
fix(my-queries): add staging config COMPASS-9663 #7502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for the atlas-staging environment configuration to resolve CORS issues preventing saved data functionality in the staging environment (cloud-stage.mongodb.com).
Key Changes:
- Added
atlas-stagingas a new backend preset option - Configured staging environment endpoints and authentication settings
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/compass-preferences-model/src/preferences-schema.tsx | Added atlas-staging to the list of valid backend presets and updated documentation |
| packages/atlas-service/src/util.ts | Added complete staging environment configuration with API endpoints and OAuth settings |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| * - atlas-local: local mms backend (localhost) | ||
| * - atlas-dev: dev mms backend (cloud-dev.mongodb.com) | ||
| * - atlas-qa: qa mms backend (cloud-qa.mongodb.com) | ||
| * - atlas-staging: staging mms backend (cloud-stage.mongodb.com) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit should we call it atlas-stage to mirror the actual env name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question lol, I've been meaning to get to the bottom of why it's called "stage" only for the MMS URL and it's called "staging" literally everywhere else
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "staging" is actually the more common name and "stage" is the exception
johnjackweir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one nit but not blocking
Description
Adding a config for cloud-stage.mongodb.com. Previously, this was preventing saved data from working in stage due to CORS issues.
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes