chore(scripts): print progress in changed script #7574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
added
no release notes
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds progress tracking to the changed packages script by displaying the current package number and total package count during iteration. This provides better visibility into the script's execution progress.
Key Changes:
- Added progress counter to display "current/total" format when processing packages
- Stores the total package count at the start of execution for reference
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lerouxb
reviewed
Nov 17, 2025
| console.log(); | ||
|
|
||
| const pkg = packages[0]; | ||
| const currentIndex = totalPackages - packages.length + 1; |
Contributor
There was a problem hiding this comment.
Took me a moment to realise that this is inside a while (packages.length)
Contributor
Author
There was a problem hiding this comment.
Yeah. I have no idea why that was chosen originally.
lerouxb
approved these changes
Nov 17, 2025
nbbeeken
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small suggestion to print package current + total packages while iterating over changed packages.
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes