chore(connection-form): screenshot on failure to setup default connections #7576
Conversation
kraenhansen
added
no release notes
There was a problem hiding this comment.
Pull Request Overview
This PR adds error handling to the setupDefaultConnections function to capture screenshots when connection setup fails during test execution. This is particularly useful since connection setup often runs as a before hook, which doesn't automatically capture screenshots on failure.
- Wraps the default connection setup loop in a try-catch block
- Captures a screenshot with an incrementing counter when errors occur during setup
- Re-throws the error to maintain existing error handling behavior
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| .waitForDisplayed({ reverse: true }); | ||
| } | ||
|
|
||
| let screenshotCounter = 0; |
There was a problem hiding this comment.
The module-level screenshotCounter variable will persist across multiple test runs within the same process, potentially causing confusion in screenshot filenames. Consider resetting this counter at appropriate test lifecycle points or including a timestamp in the filename instead.
There was a problem hiding this comment.
This is the exact point of the counter 😆
Description
Had a need for screenshot while debugging the default connections, which often runs as before hook and therefore won't get screenshotted on failures, as-is.
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes