COMPASS-586: Improve Linux appearance (logo in popups/about box, ...) #762
Conversation
|
Tests are failing due to: |
|
@imlucas Will have a go at this after 🎾 a few hours from now, though if you're up and can link an Evergreen patch build it would be appreciated so I don't have to dig up instructions on how to do that again, thanks 👍 . EDIT: Got one, always forgetting to evergreen patch --project=10gen-compass-master -v all -t all --yes --finalize Waiting on build to test: |
|
@imlucas I can confirm the updated About Window still works with my Evergreen patch build, but I'm getting an ENOTDIR console error when Compass tries to render the connect dialog:
As it's the Australia Day public holiday tomorrow I won't have time to look into what caused it to change relative to the working |
There was a problem hiding this comment.
Code looks 👍 to me, just can't get nice screenshots for the blog yet.
We'd need to figure out what's causing the ENOTDIR console error and if it's related to the Connect Window not loading (and whether it's just me, some Evergreen issue, the 1.7.0-dev build changes relative to 1.6.0-beta.0 or something in between, and/or affects our Compass AWS test Red Hat box too).
|
For info I am testing the RPM file from Evergreen, I should also test the .tar.gz if time permits on Friday as that might be a workaround so we can continue to make some progress. |
|
Thanks @pzrq. I believe the |
…#762) * COMPASS-586: Improve Linux appearance (logo in popups/about box, ...) * assert.equals => assert.equal
…#762) * COMPASS-586: Improve Linux appearance (logo in popups/about box, ...) * assert.equals => assert.equal
…#762) * COMPASS-586: Improve Linux appearance (logo in popups/about box, ...) * assert.equals => assert.equal
…#762) * COMPASS-586: Improve Linux appearance (logo in popups/about box, ...) * assert.equals => assert.equal
* COMPASS-586: Improve Linux appearance (logo in popups/about box, ...) (#762) * COMPASS-586: Improve Linux appearance (logo in popups/about box, ...) * assert.equals => assert.equal * [Selectively cherry-picked from COMPASS 701 Charts] * Extract PackageManager setup into its own file So I can possibly reuse it in tests where I’d like to test our listenToExternalStore wiring. * Expand the --renderer test so it can handle integration tests Tried several times to get this into the --unit tests, but our internal-packages tend to depend on “window” and “document” so that is not possible. Both those are genuinely available in the renderer process so it’s definitely a better home for these tests for now. We can decide later when we have more if they can or should be decoupled further. * COMPASS-788: mongodb:// in clipboard message has regressed on macOS / Red Hat (#787) * Fix white screen and icon on macOS If you have a string prefixed with `mongodb://`, e.g. every Atlas URL, present in your clipboard. * Fix icon on Share Schema as JSON message box Tested on a Red Hat VirtualBox VM, as per: https://github.com/10gen/compass-internal-docs/pull/4 * Add regression test for the share-schema-as-json feature Not unit testing the Ampersand View clipboard version as I have no idea how to do so. * Update hadron-app => ampersand-app As we don’t expect to back port b4a5a26 * Add ‘undefined’ to share-schema-as-json test Not sure why this is ‘undefined’ on this branch but not master, but there’s a lot of hadron-app and other changes floating around so it probably doesn’t matter.
3 participants
This pull request updates our usage of electron's
BrowserWindowanddialogin Compass so the Compass icon is shown on Linux instead of the default system icons.After
Before