COMPASS-803 Backport COMPASS-586 COMPASS-788 icon changes #792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzrq
force-pushed
the
COMPASS-803-backport-586-788
branch
2 times, most recently
from
0f02317 to
d0adeba
Compare
…#762) * COMPASS-586: Improve Linux appearance (logo in popups/about box, ...) * assert.equals => assert.equal
… Red Hat (#787) * Fix white screen and icon on macOS If you have a string prefixed with `mongodb://`, e.g. every Atlas URL, present in your clipboard. * Fix icon on Share Schema as JSON message box Tested on a Red Hat VirtualBox VM, as per: https://github.com/10gen/compass-internal-docs/pull/4 * Add regression test for the share-schema-as-json feature Not unit testing the Ampersand View clipboard version as I have no idea how to do so.
As we don’t expect to back port b4a5a26
* Extract PackageManager setup into its own file So I can possibly reuse it in tests where I’d like to test our listenToExternalStore wiring. * Expand the --renderer test so it can handle integration tests Tried several times to get this into the --unit tests, but our internal-packages tend to depend on “window” and “document” so that is not possible. Both those are genuinely available in the renderer process so it’s definitely a better home for these tests for now. We can decide later when we have more if they can or should be decoupled further.
pzrq
force-pushed
the
COMPASS-803-backport-586-788
branch
from
d0adeba to
0a0a8b6
Compare
Not sure why this is ‘undefined’ on this branch but not master, but there’s a lot of hadron-app and other changes floating around so it probably doesn’t matter.
|
@rueckstiess @imlucas Whoever gets here first, if you agree with these changes to |
|
Thanks for reviewing @imlucas 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEFORE (on 1.6-releases, e.g. no new query bar which you'd see on master for 1.7+)
AFTER
