COMPASS-788: mongodb:// in clipboard message has regressed on macOS / Red Hat #787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah perfect. Mind changing this for schema copy Json dialog as well in schema store? Should be all set after that. |
pzrq
force-pushed
the
COMPASS-788-start
branch
from
7db6a9c to
129fe0d
Compare
|
@imlucas Thanks! Added a test and fix for Share Schema (as JSON). New screenshots, following https://docs.mongodb.com/manual/tutorial/install-mongodb-on-red-hat/
|
pzrq
changed the title
If you have a string prefixed with `mongodb://`, e.g. every Atlas URL, present in your clipboard.
Not unit testing the Ampersand View clipboard version as I have no idea how to do so.
Tested on a Red Hat VirtualBox VM, as per: https://github.com/10gen/compass-internal-docs/pull/4
pzrq
force-pushed
the
COMPASS-788-start
branch
from
129fe0d to
142f35b
Compare
pzrq
added a commit
that referenced
this pull request
Feb 23, 2017
… Red Hat (#787) * Fix white screen and icon on macOS If you have a string prefixed with `mongodb://`, e.g. every Atlas URL, present in your clipboard. * Fix icon on Share Schema as JSON message box Tested on a Red Hat VirtualBox VM, as per: https://github.com/10gen/compass-internal-docs/pull/4 * Add regression test for the share-schema-as-json feature Not unit testing the Ampersand View clipboard version as I have no idea how to do so.
|
Thanks @imlucas |
pzrq
added a commit
that referenced
this pull request
Feb 23, 2017
… Red Hat (#787) * Fix white screen and icon on macOS If you have a string prefixed with `mongodb://`, e.g. every Atlas URL, present in your clipboard. * Fix icon on Share Schema as JSON message box Tested on a Red Hat VirtualBox VM, as per: https://github.com/10gen/compass-internal-docs/pull/4 * Add regression test for the share-schema-as-json feature Not unit testing the Ampersand View clipboard version as I have no idea how to do so.
pzrq
added a commit
that referenced
this pull request
Feb 23, 2017
… Red Hat (#787) * Fix white screen and icon on macOS If you have a string prefixed with `mongodb://`, e.g. every Atlas URL, present in your clipboard. * Fix icon on Share Schema as JSON message box Tested on a Red Hat VirtualBox VM, as per: https://github.com/10gen/compass-internal-docs/pull/4 * Add regression test for the share-schema-as-json feature Not unit testing the Ampersand View clipboard version as I have no idea how to do so.
pzrq
added a commit
that referenced
this pull request
Feb 23, 2017
… Red Hat (#787) * Fix white screen and icon on macOS If you have a string prefixed with `mongodb://`, e.g. every Atlas URL, present in your clipboard. * Fix icon on Share Schema as JSON message box Tested on a Red Hat VirtualBox VM, as per: https://github.com/10gen/compass-internal-docs/pull/4 * Add regression test for the share-schema-as-json feature Not unit testing the Ampersand View clipboard version as I have no idea how to do so.
imlucas
pushed a commit
that referenced
this pull request
Feb 23, 2017
* COMPASS-586: Improve Linux appearance (logo in popups/about box, ...) (#762) * COMPASS-586: Improve Linux appearance (logo in popups/about box, ...) * assert.equals => assert.equal * [Selectively cherry-picked from COMPASS 701 Charts] * Extract PackageManager setup into its own file So I can possibly reuse it in tests where I’d like to test our listenToExternalStore wiring. * Expand the --renderer test so it can handle integration tests Tried several times to get this into the --unit tests, but our internal-packages tend to depend on “window” and “document” so that is not possible. Both those are genuinely available in the renderer process so it’s definitely a better home for these tests for now. We can decide later when we have more if they can or should be decoupled further. * COMPASS-788: mongodb:// in clipboard message has regressed on macOS / Red Hat (#787) * Fix white screen and icon on macOS If you have a string prefixed with `mongodb://`, e.g. every Atlas URL, present in your clipboard. * Fix icon on Share Schema as JSON message box Tested on a Red Hat VirtualBox VM, as per: https://github.com/10gen/compass-internal-docs/pull/4 * Add regression test for the share-schema-as-json feature Not unit testing the Ampersand View clipboard version as I have no idea how to do so. * Update hadron-app => ampersand-app As we don’t expect to back port b4a5a26 * Add ‘undefined’ to share-schema-as-json test Not sure why this is ‘undefined’ on this branch but not master, but there’s a lot of hadron-app and other changes floating around so it probably doesn’t matter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this is just a POC, if someone else has time to pick this up and properly identify what to test, and which platforms to test it on (please assign yourself and remove this paragraph 🍻) it would be appreciated, otherwise I'll pick this up when it bugs me enough to fix it.
TODO
showMessageBox, or if this is an Electron bug (and if it is fixed in a new Electron). (Path is good enough when usingBrowserWindow.getFocusedWindow()as first argument toelectron.remote.dialog.showMessageBox)BEFORE (note the Intercom icon loaded too)
AFTER