feat: Fix bug where models were not listened to when they were set as properties, after initial construction.

Author: bradvogel

lib/connect-backbone-to-react.js

@@ -90,10 +90,13 @@ module.exports = function connectBackboneToReact(
       createEventListeners() {
         Object.keys(this.models).forEach(mapKey => {
           const model = this.models[mapKey];
+          this.createEventListener(mapKey, model);
+        });
+      }
 
-          getEventNames(mapKey).forEach(name => {
-            model.on(name, this.createNewProps, this);
-          });
+      createEventListener(modelName, model) {
+        getEventNames(modelName).forEach(name => {
+          model.on(name, this.createNewProps, this);
         });
       }
 
@@ -112,6 +115,17 @@ module.exports = function connectBackboneToReact(
       componentWillReceiveProps(nextProps, nextContext) {
         this.setModels(nextProps, nextContext);
         this.createNewProps();
+
+        // Bind event listeners for each model that changed.
+        Object.keys(this.models).forEach(mapKey => {
+          const model = this.models[mapKey];
+          if (this.props.models[mapKey] === this.models[mapKey] ||
+            (this.context.models && this.context.models[mapKey] === this.models[mapKey])) {
+            return; // Did not change.
+          }
+
+          this.createEventListener(mapKey, model);
+        });
       }
 
       componentWillUnmount() {

test/connect-backbone-to-react.test.js

@@ -477,6 +477,7 @@ describe('connectBackboneToReact', function() {
     let setStateSpy;
     let newName;
     let newAge;
+    let newUserModel;
 
     beforeEach(function() {
       const ConnectedTest = connectBackboneToReact(mapModelsToProps)(TestComponent);
@@ -488,7 +489,7 @@ describe('connectBackboneToReact', function() {
       newName = 'Robert';
       newAge = '30';
 
-      const newUserModel = new UserModel({
+      newUserModel = new UserModel({
         name: newName,
         age: newAge,
         hungry: false,
@@ -514,6 +515,13 @@ describe('connectBackboneToReact', function() {
       assert.equal(stub.find('.age').text(), newAge);
       assert.equal(stub.find('.hungry').text(), 'not hungry');
     });
+
+    it('listen for updates', function() {
+      newName = 'Bob';
+      newUserModel.set('name', newName);
+
+      assert.equal(stub.find('.name').text(), newName);
+    });
   });
 
   describe('when unmounted in an event listener and subscribed to "all" event', function() {