fix(mongodb-runner): forward all server log entries to debug #583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, enabling `mongodb-runner:verbose` debug logs lets you read all server logs. This should help debug the server setup errors we've been seeing in mongosh CI.
gagik
approved these changes
Oct 21, 2025
| Promise.allSettled([once(stdout, 'end'), once(stderr, 'end')]).then( | ||
| () => outStream.end(), | ||
| () => { | ||
| /* ignore error */ |
Collaborator
There was a problem hiding this comment.
is this still not ignoring an error?
Collaborator
Author
There was a problem hiding this comment.
.allSettled() never rejects, hence the change in description here – the behavior is similar (but now we always wait for both stdout and stderr to be closed successfully instead of one of them potentially closing because of an error)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, enabling
mongodb-runner:verbosedebug logs lets you read all server logs.This should help debug the server setup errors we've been seeing in mongosh CI.
Description
Open Questions
Checklist