feat(query-parser, shell-bson-parser, constants): add shell helpers for legacy UUID MONGOSH-2486 #594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anemy
commented
Nov 13, 2025
| LegacyJavaUUID: function (u: any) { | ||
| if (u === undefined) { | ||
| // Generate a new UUID and format it. | ||
| u = new bson.UUID().toHexString(); |
Member
Author
There was a problem hiding this comment.
Chatting with @nbbeeken I think we were thinking of throwing an error here instead. This is when someone writes new LegacyJavaUUID() without a string in the quotes. Currently UUID creates a new UUID so I had initially written it to also generate a new UUID (of subtype 3).
Any other opinions on if it we should throw an error or allow it? I'll add an error throw otherwise. I'll ask Betsy on it too.
Anemy
commented
Nov 13, 2025
| snippet: "LegacyPythonUUID('${1:uuid}')", | ||
| }, | ||
| { | ||
| name: 'UUID', |
Member
Author
There was a problem hiding this comment.
Previously UUID didn't show up in Compass' autocomplete. I'm thinking it was just missing. This will make it start showing up:
Anemy
commented
Nov 13, 2025
| value: 'LegacyJavaUUID', | ||
| label: 'LegacyJavaUUID', | ||
| score: 1, | ||
| meta: 'bson-legacy-uuid', |
Member
Author
There was a problem hiding this comment.
The meta here will make it into Compass' autocompleter:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MONGOSH-2486
Description
Adds
LegacyJavaUUID,LegacyCSharpUUID, andLegacyPythonUUIDhelpers to the query-parser, shell-bson-parser, and mongodb-constants. These are ways for folks to pass a UUID string in the canonical form00112233-4455-6677-8899-aabbccddeeffand have it encoded how the various legacy implementations did it. See the short history of UUIDs for more info.In the next ticket, COMPASS-9690, we'll be adding this to Compass and providing a setting to customize how we're rendering the Binary subtype 3. We won't be adding that in mongosh, we'll keep showing the format
Binary.createFromBase64('Y7mFuOjdS9qQh+RALxo/9g==', 3).https://www.mongodb.com/docs/languages/python/pymongo-driver/current/data-formats/uuid/#a-short-history-of-mongodb-uuids
Brief: UUID Support in Compass & Mongosh