fix(mongodb-redact): redact special character cases for password MONGOSH-2991 #597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagik
commented
Nov 17, 2025
addaleax
approved these changes
Nov 17, 2025
gagik
force-pushed
the
gagik/fix-redact
branch
from
139e6af to
93b40a8
Compare
gagik
commented
Nov 18, 2025
| ], | ||
|
|
||
| // MongoDB connection strings | ||
| [/mongodb(?:\+srv)?:\/\/\S+/gim, '<mongodb uri>'], |
Collaborator
Author
There was a problem hiding this comment.
I figured we might as well be very liberal and match any mongodb(+srv):// until we see a whitespace.
Alternatively, we can just redact the credentials by using mongodb-connection-url? I'm currently sticking to this as I guess the idea here is that URI itself is sensitive.
gagik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a negative condition regex for the taking care of secrets.
I think we might need to update the URI regex too.