This repository was archived by the owner on May 17, 2021. It is now read-only.
fix: COMPASS-4209: Add missing returns on error cases #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fair enough, LGTM. I just tried the most recent beta and could not reproduce it either. |
mmarcon
approved these changes
Apr 14, 2020
imlucas
added a commit
to mongodb-js/data-service
that referenced
this pull request
Apr 14, 2020
imlucas
added a commit
to mongodb-js/compass
that referenced
this pull request
Apr 14, 2020
10 tasks
imlucas
added a commit
to mongodb-js/compass
that referenced
this pull request
Apr 14, 2020
imlucas
added a commit
to mongodb-js/compass
that referenced
this pull request
Apr 14, 2020
gribnoysup
pushed a commit
to mongodb-js/compass
that referenced
this pull request
Apr 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mmarcon while I'm not able to reproduce this issue in Compass, this PR adds guards and additional error debugging so we'll have more information aside from callback already called.