chore: add tests and pre-processor for other cases

Author: gagik

src/common/config/configUtils.ts

@@ -69,8 +69,11 @@ export function commaSeparatedToArray<T extends string[]>(str: string | string[]
         return undefined;
     }
 
-    if (!Array.isArray(str)) {
-        return [str] as T;
+    if (typeof str === "string") {
+        return str
+            .split(",")
+            .map((e) => e.trim())
+            .filter((e) => e.length > 0) as T;
     }
 
     if (str.length === 1) {
@@ -82,3 +85,24 @@ export function commaSeparatedToArray<T extends string[]>(str: string | string[]
 
     return str as T;
 }
+
+/**
+ * Preprocessor for boolean values that handles string "false"/"0" correctly.
+ * Zod's coerce.boolean() treats any non-empty string as true, which is not what we want.
+ */
+export function parseBoolean(val: unknown): unknown {
+    if (typeof val === "string") {
+        const lower = val.toLowerCase().trim();
+        if (lower === "false" || lower === "") {
+            return false;
+        }
+        return true;
+    }
+    if (typeof val === "boolean") {
+        return val;
+    }
+    if (typeof val === "number") {
+        return val !== 0;
+    }
+    return !!val;
+}

src/common/config/userConfig.ts

@@ -1,6 +1,12 @@
 import { z as z4 } from "zod/v4";
 import { type CliOptions } from "@mongosh/arg-parser";
-import { type ConfigFieldMeta, commaSeparatedToArray, getExportsPath, getLogPath } from "./configUtils.js";
+import {
+    type ConfigFieldMeta,
+    commaSeparatedToArray,
+    getExportsPath,
+    getLogPath,
+    parseBoolean,
+} from "./configUtils.js";
 import { previewFeatureValues, similarityValues } from "../schemas.js";
 
 // TODO: UserConfig should only be UserConfigSchema and not an intersection with
@@ -68,13 +74,13 @@ export const UserConfigSchema = z4.object({
             "An array of tool names that require user confirmation before execution. Requires the client to support elicitation."
         ),
     readOnly: z4
-        .boolean()
+        .preprocess(parseBoolean, z4.boolean())
         .default(false)
         .describe(
             "When set to true, only allows read, connect, and metadata operation types, disabling create/update/delete operations."
         ),
     indexCheck: z4
-        .boolean()
+        .preprocess(parseBoolean, z4.boolean())
         .default(false)
         .describe(
             "When set to true, enforces that query operations must use an index, rejecting queries that perform a collection scan."
@@ -149,7 +155,7 @@ export const UserConfigSchema = z4.object({
         )
         .register(configRegistry, { isSecret: true }),
     disableEmbeddingsValidation: z4
-        .boolean()
+        .preprocess(parseBoolean, z4.boolean())
         .default(false)
         .describe("When set to true, disables validation of embeddings dimensions."),
     vectorSearchDimensions: z4.coerce

tests/unit/common/config.test.ts

@@ -450,6 +450,44 @@ describe("config", () => {
                     cli: ["--version"],
                     expected: { version: true },
                 },
+                {
+                    cli: ["--readOnly"],
+                    expected: { readOnly: true },
+                },
+                {
+                    cli: ["--readOnly", "false"],
+                    expected: { readOnly: false },
+                },
+                {
+                    cli: ["--readOnly", "FALSE"],
+                    // This is yargs-parser default
+                    expected: { readOnly: true },
+                },
+                {
+                    cli: ["--readOnly", "0"],
+                    // This is yargs-parser default
+                    expected: { readOnly: true },
+                },
+                {
+                    cli: ["--readOnly", "1"],
+                    expected: { readOnly: true },
+                },
+                {
+                    cli: ["--readOnly", "true"],
+                    expected: { readOnly: true },
+                },
+                {
+                    cli: ["--readOnly", "yes"],
+                    expected: { readOnly: true },
+                },
+                {
+                    cli: ["--readOnly", "no"],
+                    expected: { readOnly: true },
+                },
+                {
+                    cli: ["--readOnly", ""],
+                    expected: { readOnly: true },
+                },
             ] as { cli: string[]; expected: Partial<UserConfig> }[];
 
             for (const { cli, expected } of testCases) {