feat: adds support for dropping vector search indexes in drop-index tool MCP-239 #642
+897
−354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new drop-search-index tool for dropping search indexes from MongoDB collections. The tool is currently restricted to test environments and includes elicitation (confirmation) functionality for safety.
- Introduces a new
drop-search-indextool with proper validation, error handling, and elicitation support - Refactors existing search index functionality to support code reuse between list and drop operations
- Adds comprehensive test coverage including unit, integration, and elicitation tests
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/tools/mongodb/delete/dropSearchIndex.ts | New tool implementation for dropping search indexes with validation and confirmation |
| src/tools/mongodb/search/listSearchIndexes.ts | Refactored to extract reusable search index retrieval logic |
| src/tools/mongodb/tools.ts | Added the new tool to the exports list |
| src/common/config.ts | Added drop-search-index to confirmation required tools list |
| tests/integration/tools/mongodb/delete/dropSearchIndex.test.ts | Comprehensive test suite for the new tool |
| tests/integration/tools/mongodb/search/listSearchIndexes.test.ts | Updated to use refactored helper functions |
| tests/integration/helpers.ts | Added reusable helper functions for search index operations |
| tests/integration/tools/mongodb/mongodbClusterProcess.ts | Added directConnection parameter to connection string |
himanshusinghs
changed the title
himanshusinghs
force-pushed
the
feat/MCP-239-delete-vector-search-indexes
branch
from
4e0e3e0 to
3df48c4
Compare
Pull Request Test Coverage Report for Build 18562320578Details
💛 - Coveralls |
himanshusinghs
force-pushed
the
feat/MCP-239-delete-vector-search-indexes
branch
4 times, most recently
from
10f49db to
d6f1b91
Compare
- Tool is currently only visible to tests - Tool has been added to the list of tools requiring elicitation - Tests have been added for basic tool functionality and elicitation - listSearchIndexes tool and its tests have been modified to re-use some of the existing code.
1. Wraps the toolcall result in untrusted data wrapper 2. Add additional test for confirming that we don't drop when confirmation is not provided
himanshusinghs
force-pushed
the
feat/MCP-239-delete-vector-search-indexes
branch
from
effaac6 to
7d795ca
Compare
himanshusinghs
changed the title
himanshusinghs
changed the title
kmruiz
reviewed
Oct 15, 2025
kmruiz
reviewed
Oct 15, 2025
kmruiz
reviewed
Oct 15, 2025
kmruiz
reviewed
Oct 15, 2025
kmruiz
reviewed
Oct 16, 2025
kmruiz
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds support for dropping vector search indexes in drop-index tool. The functionality is behind a feature flag.
Checklist