chore: Support atlas connect via private and private endpoint connection strings #673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cveticm
force-pushed
the
mc/MCP-259_atlas_private_connStr_and_privateEndpoint
branch
from
4f8f307 to
80b353f
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for connecting to MongoDB Atlas clusters using private and private endpoint connection strings, in addition to the existing standard connection string option.
Key changes:
- Introduces a
connectionTypeparameter to theconnect-clustertool, allowing users to specify "standard", "private", or "privateEndpoint" connection types - Refactors the cluster data model to store all connection string types instead of just a single connection string
- Updates cluster listing and inspection tools to display the appropriate connection string based on availability
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/tools/atlas/connect/connectCluster.ts | Adds connectionType parameter to support private/privateEndpoint connections and updates connection preparation logic |
| src/tools/args.ts | Defines new connectionType Zod schema with enum validation for the three connection types |
| src/common/atlas/cluster.ts | Adds getConnectionString helper function and refactors Cluster interface to store all connection strings instead of a single string |
| src/tools/atlas/read/listClusters.ts | Updates cluster listing to use new connection strings structure |
| src/tools/atlas/read/inspectCluster.ts | Updates cluster inspection to use new connection strings structure |
cveticm
changed the title
gagik
approved these changes
Oct 23, 2025
| } | ||
| const connectionString = getConnectionString(cluster.connectionStrings, connectionType); | ||
| if (connectionString === undefined) { | ||
| throw new Error(`Connection string for connection type "${connectionType}" not available`); |
There was a problem hiding this comment.
is there something we could instruct or recommend them / the model to do in this case?
There was a problem hiding this comment.
Good point. I'll expand the error message to point to atlas docs on connecting to clusters
cveticm
deleted the
mc/MCP-259_atlas_private_connStr_and_privateEndpoint
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds new optional input for
atlas-connect-clusterconnectionType. This allows users to connect via standard, private, or private endpoint connection strings.Manual Testing
Although I was unable to successfully set up a PE to test the connection in a timely manner, I have verified that the PE connection string obtained in this tool matches that which is provided when connection via the Atlas UI.
mongodb+srv://<user>:<password>@<cluster-name>-pl-<...>.mongodb-dev.net/?authSource=adminJIRA ticket: MCP-259
Checklist