fix duplicated symbol in compiled binary #248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested on macOS, works well. |
lrlna
approved these changes
Jul 1, 2020
|
I am confused why the regular windows tests are running here -- i am sure we removed that task in master. |
|
Ah good catch!! Sorry I missed this - I tested with the binary before I made the final switch of adding the second symbol, but going forward will always test with the binary as a final step. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
export const shellApiType = Symbol('...')is working fine in node js withnpm run startbut in the binary we get actually 2 distinct unique symbols: one used in the class definition and one used in the shell evaluator.To fix this we use
Symbol.for('...')with a unique name.