chore(browser-repl): bump puppeteer dev dep & pass puppeteer_skip_download to the right function #2591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lerouxb
added
the
no-title-validation
There was a problem hiding this comment.
Pull request overview
Updates the puppeteer dev dependency from version ^21.0.3 to ^24.31.0 to incorporate a fix for PUPPETEER_SKIP_DOWNLOAD environment variable handling, which previously incorrectly evaluated both "true" and "false" strings as truthy values.
Key Changes
- Bumped puppeteer from ^21.0.3 to ^24.31.0 in devDependencies
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gagik
approved these changes
Nov 26, 2025
kmruiz
approved these changes
Nov 26, 2025
Contributor
Author
|
yay 
|
lerouxb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so we can take in this fix.
We set PUPPETEER_SKIP_DOWNLOAD to "true" or "false" both of which are interpreted as truthy before that fix and no I have no idea how this ever worked before.
We also passed
puppeteer_skip_downloaddown to thetestfunction in evergreen and it is actually a parameter of theinstallfunction.