chore: fix auxiliary publishing for @aws-sdk/client-sts
#2610
Conversation
gagik
added
the
no-title-validation
There was a problem hiding this comment.
Pull request overview
This PR fixes an auxiliary publishing issue related to @aws-sdk/client-sts in the webpack configuration. The change ensures that the optional peer dependency is properly externalized during the build process.
Key Changes:
- Added
@aws-sdk/client-ststo webpack externals configuration
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| 'os-dns-native': 'commonjs2 os-dns-native', | ||
| 'system-ca': 'commonjs2 system-ca', | ||
| // @aws-sdk/client-sts is an optional peer dependency of @aws-sdk/credential-providers | ||
| '@aws-sdk/client-sts': 'commonjs2 @aws-sdk/client-sts', |
There was a problem hiding this comment.
Hmmm ... maybe a TODO ticket to clean this up?
But I don't think we should just make this a webpack external because it doesn't happen to get installed in CI. For Evergreen, we have a script (scripts/mark-ci-required-optional-dependencies.ts) to actually mark the "required optional" dependencies as required because we know we want them in CI (just not necessarily on user machines when they run e.g. npx mongosh). Maybe a similar approach makes sense here?
As part of the Node.js 24 upgrade project, we'll need to take care of making the @aws-sdk/credential-providers package a hard dependency of service-provider-node-driver, so this may change as part of that (I don't quite know how), hence the suggestion of a TODO ticket rather than doing something right now
I cannnot reproduce this one locally but this seems to be in same spirit:
https://github.com/mongodb-js/mongosh/actions/runs/19894601536/job/57021652772#step:6:665
Maybe we should add
webpack-buildas part of check? I don't really understand how tests pass.