Remove recheck deduplication logic #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdq45gj
reviewed
Nov 5, 2025
| generation, _ := verifier.getGenerationWhileLocked() | ||
|
|
||
| eg, groupCtx := contextplus.ErrGroup(ctx) | ||
| eg.SetLimit(100) |
Collaborator
There was a problem hiding this comment.
Why are we setting the limit?
Collaborator
Author
There was a problem hiding this comment.
Without this, the driver fails requests with errors about not being able to get a thread within 30s or so. This way we throttle the requests to avoid “upsetting” the driver.
Collaborator
There was a problem hiding this comment.
Interesting. Would appreciate this information to be added to code comment.
tdq45gj
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 440bcb4 added logic to deduplicate rechecks on insert. With large inserts, though, that logic hurts more than it helps.