Skip to content

Improve logging statements’ accuracy and reporting of data points. #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 15, 2024
Merged

Improve logging statements’ accuracy and reporting of data points. #44

merged 3 commits into from
Nov 15, 2024

Conversation

@FGasper
Copy link
Collaborator

@FGasper FGasper commented Nov 15, 2024 •
edited
Loading

This changeset improves several logs by:

  • reporting their data points as structured data rather than phrase components
  • including the task ID (“PrimaryKey” in code) to facilitate correlation among logs and metadata
  • adding a few other data points and adding new log events such as task-finished

@FGasper FGasper marked this pull request as ready for review November 15, 2024 02:17
@FGasper FGasper requested a review from tdq45gj November 15, 2024 02:17
tdq45gj
tdq45gj approved these changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@tdq45gj tdq45gj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FGasper FGasper merged commit 25c320f into mongodb-labs:main Nov 15, 2024
5 checks passed
@FGasper FGasper deleted the logging_improvements branch November 15, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tdq45gj tdq45gj tdq45gj approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FGasper @tdq45gj