Add a worker tracker to migration-verifier’s progress logs. #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FGasper
added a commit
to FGasper/migration-verifier
that referenced
this pull request
Nov 30, 2024
- This makes reportutils.FmtBytes() postfix the unit after the number; previously it just returned the (stringified) number. - This makes the “Check finished” log print if there is no error, not if there is an error. (The logic had been reversed.) - This suppresses the “No tasks found” log. (PR mongodb-labs#60 meant to do this.) - This unsets worker tracker entries once they are done being processed. (Previously they were not cleared, which made the worker tracker table much less meaningful because entries were never removed, only replaced.) - This suppresses the findCmd log for recheck tasks since the list of IDs can be long. - This suppresses the “Finished document comparison task” log if that task fails.
FGasper
added a commit
to FGasper/migration-verifier
that referenced
this pull request
Nov 30, 2024
- This makes reportutils.FmtBytes() postfix the unit after the number; previously it just returned the (stringified) number. - This makes the “Check finished” log print if there is no error, not if there is an error. (The logic had been reversed.) - This suppresses the “No tasks found” log. (PR mongodb-labs#60 meant to do this.) - This unsets worker tracker entries once they are done being processed. (Previously they were not cleared, which made the worker tracker table much less meaningful because entries were never removed, only replaced.) - This suppresses the findCmd log for recheck tasks since the list of IDs can be long. - This suppresses the “Finished document comparison task” log if that task fails.
FGasper
added a commit
to FGasper/migration-verifier
that referenced
this pull request
Dec 1, 2024
- This makes reportutils.FmtBytes() postfix the unit after the number; previously it just returned the (stringified) number. - This makes the “Check finished” log print if there is no error, not if there is an error. (The logic had been reversed.) - This suppresses the “No tasks found” log. (PR mongodb-labs#60 meant to do this.) - This unsets worker tracker entries once they are done being processed. (Previously they were not cleared, which made the worker tracker table much less meaningful because entries were never removed, only replaced.) - This suppresses the findCmd log for recheck tasks since the list of IDs can be long. - This suppresses the “Finished document comparison task” log if that task fails.
FGasper
added a commit
that referenced
this pull request
Dec 2, 2024
- This makes reportutils.FmtBytes() postfix the unit after the number; previously it just returned the (stringified) number. - This makes the “Check finished” log print if there is no error, not if there is an error. (The logic had been reversed.) - This suppresses the “No tasks found” log. (PR #60 meant to do this.) - This unsets worker tracker entries once they are done being processed. (Previously they were not cleared, which made the worker tracker table much less meaningful because entries were never removed, only replaced.) - This suppresses the findCmd log for recheck tasks since the list of IDs can be long. - This suppresses the “Finished document comparison task” log if that task fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset adds a table of worker thread statuses to the progress logs. This will allow at-a-glance monitoring of how long different tasks have been in progress and will usefully surface any hung threads.
This also removes the “No tasks found. Sleeping.” log messages, which convey little but add a lot of clutter.