Fix change stream lag calculation. #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdq45gj
requested changes
Dec 11, 2024
Collaborator
tdq45gj
left a comment
tdq45gj
left a comment
There was a problem hiding this comment.
The PR comment says it adds a test. Are we still adding it?
internal/verifier/change_stream.go
Outdated
| curTs, err := extractTimestampFromResumeToken(cs.ResumeToken()) | ||
| if err == nil { | ||
| lagSecs := curTs.T - sess.OperationTime().T | ||
| lagSecs := int32(sess.OperationTime().T) - int32(curTs.T) |
Collaborator
There was a problem hiding this comment.
This seems to be prone to overflow. Can we convert T (uint32) to int64?
Collaborator
Author
|
@tdq45gj I added the test. (Somehow I omitted it inadvertently earlier.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous logic was backwards, which caused uint overflow.
This adds a test that usually passes without this change but should occasionally fail. (It should always pass, though, with this change.)