Skip to content

STREAMS-1984: Add NumberInt to global scope for JS Engine #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2025
Merged

STREAMS-1984: Add NumberInt to global scope for JS Engine #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion snippets/mongocompat/mongotypes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,10 +487,16 @@ Object.defineProperty(NumberLong.prototype, 'exactValueString', {
if (!NumberInt.prototype) {
NumberInt.prototype = {};
}

NumberInt.prototype.nativeToString = NumberInt.prototype.toString;
NumberInt.prototype.toString = function() {
return `NumberInt(${this.valueOf()})`;
};
NumberInt.prototype.tojson = function() {
return this.toString();
};
NumberInt.prototype.toNumber = function() {
return this.valueOf();
};

// NumberDecimal
if (typeof NumberDecimal !== 'undefined') {
Expand Down
18 changes: 18 additions & 0 deletions snippets/mongocompat/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,24 @@ assert.strictEqual(NumberLong(2147483647).toString(), 'NumberLong(2147483647)');
assert.strictEqual(NumberLong("2147483648").toString(), 'NumberLong("2147483648")');
assert.strictEqual(NumberLong(-2147483648).toString(), 'NumberLong(-2147483648)');
assert.strictEqual(NumberLong(-2147483649).toString(), 'NumberLong("-2147483649")');

const int1 = NumberInt(42);
assert.strictEqual(int1.toString(), 'NumberInt(42)');
assert.strictEqual(int1.tojson(), 'NumberInt(42)');
assert.strictEqual(int1.toNumber(), 42);
assert.strictEqual(int1.valueOf(), 42);
assert.strictEqual(int1.toJSON(), 42);
const int2 = NumberInt(-100);
assert.strictEqual(int2.toString(), 'NumberInt(-100)');
assert.strictEqual(int2.tojson(), 'NumberInt(-100)');
assert.strictEqual(int2.toNumber(), -100);
const maxInt32 = NumberInt(2147483647);
assert.strictEqual(maxInt32.toString(), 'NumberInt(2147483647)');
assert.strictEqual(maxInt32.toNumber(), 2147483647);
const minInt32 = NumberInt(-2147483648);
assert.strictEqual(minInt32.toString(), 'NumberInt(-2147483648)');
assert.strictEqual(minInt32.toNumber(), -2147483648);

assert.strictEqual(NumberLong(9223372036854775807).toString(), 'NumberLong("9223372036854775807")');
assert.strictEqual(NumberLong(-9223372036854775808).toString(), 'NumberLong("-9223372036854775808")');
const maxLong = NumberLong(9223372036854775807, 2147483647, -1);
Expand Down