STREAMS-1982: Add singleton compat for MinKey #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@addaleax 👋 could I get a review when you get a chance? I don't have the ability to add reviewers |
tcannon91
force-pushed
the
STREAMS-1982
branch
from
0942c69 to
c1a582c
Compare
addaleax
requested changes
Nov 18, 2025
addaleax
approved these changes
Nov 21, 2025
snippets/mongocompat/test.js
Outdated
| assert(minKey instanceof MinKey, "minKey should be an instance of MinKey"); | ||
| assert.strictEqual(minKey.tojson(), '{ "$minKey" : 1 }', "minKey should serialize correctly"); | ||
| assert.strictEqual(minKey.toString(), "[object Function]", "minKey toString should work"); | ||
| assert.strictEqual(minKey.toJSON(), '{ "$minKey" : 1 }', "minKey toJSON should work"); |
Collaborator
There was a problem hiding this comment.
Not a big deal, but passing a static string as a message for assert.strictEqual() and friends is an antipattern since it will hide information about the actual comparison results – if you want to add this type of information, add a comment
Collaborator
Author
|
@addaleax I think this is ready to merge -- my latest push just addresses the comment about assertion messages. |
addaleax
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.