Skip to content

Conversation

blva
Copy link
Collaborator

@blva blva commented Aug 25, 2025

Proposed changes

Jira ticket: CLOUDP-330323

  • Updates the K8s plugin with the latest changes in atlas core library. We made some changes to extend the auth to Service Accounts, as a result that means we need to update the atlas core library with some code breaking changes, hence this PR updating how we use the library to accomodate for that.
  • We'll release the CLI, which will migrate users to the new library. Then if a customer try to use the plugin, we'll ask them to update to a newer version of the plugin for full parity.
  • The test failure seems unrelated, would be good to get feedback from k8s team about that one

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in the document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have run make fmt and formatted my code

Further comments

Co-authored-by: Melanija Cvetic <119604954+cveticm@users.noreply.github.com>
@blva blva requested a review from cveticm September 1, 2025 10:38
@blva blva marked this pull request as ready for review September 1, 2025 11:24
@blva blva requested a review from a team as a code owner September 1, 2025 11:24
Copy link
Collaborator

@cveticm cveticm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@cveticm cveticm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for delayed request, only remembered now: can we remove transport.go and another other unused files?

@blva blva requested a review from cveticm September 1, 2025 14:30
Copy link
Collaborator

@cveticm cveticm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Copy link
Collaborator

@josvazg josvazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blva blva merged commit ff2f67b into main Sep 1, 2025
16 checks passed
@blva blva deleted the CLOUDP-330323 branch September 1, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants