chore: improve boolean handling #45
Merged
+39
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Pull Request Test Coverage Report for Build 19828679258Details
💛 - Coveralls |
cveticm
reviewed
Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that booleans like
DO_NOT_TRACKandMONGODB_LOAD_SAMPLE_DATAwere treated as booleans, which is not optimal.Treat them like proper booleans now, using the same logic used in the
mongodb-atlas-localcontainer:DO_NOT_TRACKistruewhen present, regardless of the valueMONGODB_LOAD_SAMPLE_DATAistrue/falseif the lowercase string istrue/false, or the string parsed as a number is larger than0.Jira: [CLOUDP-362539] [atlas-local-lib] improve environment variable boolean handling