-
Notifications
You must be signed in to change notification settings - Fork 39
DOCSP-34690 Make cross version sync documentation clear #257
Conversation
101e9f4 to
6771e82
Compare
6771e82 to
cfaa61b
Compare
kennethdyer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kanchana-mongodb, thanks for this work. I left a few comments for your consideration.
e6911ec to
9d17a8b
Compare
kennethdyer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kanchana-mongodb. One last minor nit/suggestion for your consideration.
Otherwise this LGTM.
| versions in the first row. | ||
|
|
||
| .. list-table:: | ||
| :widths: 20 20 20 20 20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Nonblocking Nit]
You might consider using the :header-rows: and :stub-columns: options here to style the first row and first column.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I will leave it as-is as the :stub-columns: highlights the column, but :header-rows: doesn't highlight the row (it only separates the row from the other rows using an underline). So, visually, this might be better :-)
| .. _c2c-server-version-compatibility: | ||
|
|
||
| ================================================ | ||
| MongoDB Server Version Compatibility and Support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the and support part of the title adds much
| - **6.0** Destination | ||
| - **7.0** Destination | ||
|
|
||
| * - **4.4** Source |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This table should be changed. Pre-6.0 server versions aren't supported without PS support. So, I think the table should start from 6.0 and go to 7.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, because we're adding that table, I think we should change the one of the paragraphs before from:
"Starting in 1.7.0, mongosync can perform a cross-version migration from a lower major version source cluster to a higher major version destination cluster. You can migrate up to two major versions ahead. For example, you can synchronize a cluster running MongoDB 6.0 with a cluster running 7.0."
TO
"Starting in version 1.7, mongosync can perform certain cross-version migrations from a lower major version source cluster to a higher major version destination cluster."
I think this helps make the information less redundant.
rohshar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last comment, feel free to merge once addressed.
Co-authored-by: Rohan Sharan <sharanrohan@berkeley.edu>
mdb-ashley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a quick grammar fix and we're good to go! Thanks, Kanchana!
Co-authored-by: Ashley Brown <98361885+mdb-ashley@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.