Skip to content
This repository was archived by the owner on May 1, 2025. It is now read-only.

Conversation

@kanchana-mongodb
Copy link
Collaborator

@kanchana-mongodb kanchana-mongodb commented Feb 6, 2024

@kanchana-mongodb kanchana-mongodb force-pushed the DOCSP-34690 branch 5 times, most recently from 101e9f4 to 6771e82 Compare February 6, 2024 18:31
Copy link
Collaborator

@kennethdyer kennethdyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kanchana-mongodb, thanks for this work. I left a few comments for your consideration.

Copy link
Collaborator

@kennethdyer kennethdyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kanchana-mongodb. One last minor nit/suggestion for your consideration.
Otherwise this LGTM.

versions in the first row.

.. list-table::
:widths: 20 20 20 20 20
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Nonblocking Nit]

You might consider using the :header-rows: and :stub-columns: options here to style the first row and first column.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I will leave it as-is as the :stub-columns: highlights the column, but :header-rows: doesn't highlight the row (it only separates the row from the other rows using an underline). So, visually, this might be better :-)

.. _c2c-server-version-compatibility:

================================================
MongoDB Server Version Compatibility and Support
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the and support part of the title adds much

- **6.0** Destination
- **7.0** Destination

* - **4.4** Source
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This table should be changed. Pre-6.0 server versions aren't supported without PS support. So, I think the table should start from 6.0 and go to 7.0.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, because we're adding that table, I think we should change the one of the paragraphs before from:

"Starting in 1.7.0, mongosync can perform a cross-version migration from a lower major version source cluster to a higher major version destination cluster. You can migrate up to two major versions ahead. For example, you can synchronize a cluster running MongoDB 6.0 with a cluster running 7.0."

TO

"Starting in version 1.7, mongosync can perform certain cross-version migrations from a lower major version source cluster to a higher major version destination cluster."

I think this helps make the information less redundant.

Copy link
Collaborator

@rohshar rohshar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last comment, feel free to merge once addressed.

Copy link
Collaborator

@mdb-ashley mdb-ashley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick grammar fix and we're good to go! Thanks, Kanchana!

Co-authored-by: Ashley Brown <98361885+mdb-ashley@users.noreply.github.com>
@mdb-ashley mdb-ashley merged commit e6a23ee into mongodb:master Feb 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants