Skip to content
This repository was archived by the owner on May 1, 2025. It is now read-only.

Conversation

@kanchana-mongodb
Copy link
Collaborator

@kanchana-mongodb kanchana-mongodb commented Mar 1, 2024

  • JIRA
  • Stage
  • Build (contains errors and warnings not introduced by changes in this PR)

@kanchana-mongodb kanchana-mongodb force-pushed the DOCS-16038 branch 2 times, most recently from bc6236c to 48e32bb Compare March 1, 2024 15:35
Copy link
Contributor

@jocelyn-mendez1 jocelyn-mendez1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @kanchana-mongodb! This LGTM % some small suggestions!

Co-authored-by: jocelyn-mendez1 <91144778+jocelyn-mendez1@users.noreply.github.com>
@kanchana-mongodb kanchana-mongodb requested review from ivangrigolon and removed request for ivangrigolon March 5, 2024 16:55
Copy link
Collaborator

@rohshar rohshar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would someone want to unblock writes on the source after commit? I'm not sure why this would be necessary. Can you tag the original ticket filer on this PR and ask him why he filed the ticket?

@ivangrigolon
Copy link
Collaborator

LGTM


To reverse sync, the ``enableUserWriteBlocking`` field must be set
to ``true``.
to ``true``. To allow the source cluster to accept writes again, run
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kanchana-mongodb, does it make sense to include the context @ivangrigolon mentions in the comments?

Copy link
Collaborator

@mdb-ashley mdb-ashley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Kanchana! Can you request merge via the channel?

@jeff-allen-mongo jeff-allen-mongo merged commit 1965bf7 into mongodb:master Apr 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants