DOCSP-44006-mongosync-behavior-converting-legacy-indexes #442
Conversation
✅ Deploy Preview for docs-cluster-to-cluster-sync ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mdb-ashley
left a comment
mdb-ashley
left a comment
There was a problem hiding this comment.
Thanks, Anika! Let me know when this is ready for another look.
| connecting to the source and destination clusters. For more information, | ||
| see :ref:`connections-read-preference`. | ||
|
|
||
| Rewrites |
There was a problem hiding this comment.
[question] Is this the right title? Is this what would help a user understand what is being rewritten?
There was a problem hiding this comment.
Thank you for taking a look at this, @mdb-ashley !
I specified the title a bit – let me know if you think it's clearer! Also, I was a little unsure if this was the write section to put this information in. Does it seem right to you, or do you think there's a more appropriate place for it?
| Rewrites | ||
| ~~~~~~~~ | ||
|
|
||
| ``mongosync`` rewrites any legacy index values from the source to ``1`` |
There was a problem hiding this comment.
Perhaps,
"mongosync does not support legacy index values, like 0 or an empty
string. Legacy index values from the source are rewritten to 1
on the destination."
Thank you for your review, @mdb-ashley ! BTY! |
mdb-ashley
left a comment
mdb-ashley
left a comment
There was a problem hiding this comment.
LGTM! Thanks, Anika!
tdq45gj
left a comment
tdq45gj
left a comment
There was a problem hiding this comment.
Sorry, I forgot to mention in the ticket that mongosync also removes any invalid index options on the destination as part of converting legacy indexes. Could you add that to the PR as well?
| Legacy Index Value Rewrites | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| ``mongosync`` does not support legacy index values, like ``0`` or an empty |
There was a problem hiding this comment.
I feel "does not support" means that it's a limitation and is not allowed. But mongosync is actually handling legacy index values in this case.
There was a problem hiding this comment.
thanks for taking a look at this, @tdq45gj ! BTY!
* DOCSP-44006-mongosync-behavior-converting-legacy-indexes * remove reference to valid value * reword and change title of subsection * add other mongosync behavior, remove mention of not supporting legacy index vals
4 participants
DESCRIPTION
Mongosync rewrites any legacy index key values that is 0 or an empty string from the source to a valid value (1) on the destination. This should be documented on the mongosync behavior page.
STAGING
https://deploy-preview-442--docs-cluster-to-cluster-sync.netlify.app/reference/mongosync/mongosync-behavior/#legacy-index-value-rewrites
JIRA
https://jira.mongodb.org/browse/DOCSP-44006
SELF-REVIEW CHECKLIST
See the taxonomy tagging instructions and this example PR
EXTERNAL REVIEW REQUIREMENTS
What's expected of an external reviewer?