Skip to content
This repository was archived by the owner on May 1, 2025. It is now read-only.

Conversation

@ltran-mdb2
Copy link
Collaborator

@ltran-mdb2 ltran-mdb2 commented Oct 30, 2024

DESCRIPTION

Adds rolling index limitation

STAGING

https://deploy-preview-457--docs-cluster-to-cluster-sync.netlify.app/reference/limitations/#rolling-index-builds

JIRA

https://jira.mongodb.org/browse/DOCSP-44876

SELF-REVIEW CHECKLIST

  • Does each file have 3-5 taxonomy facet tags?
    See the taxonomy tagging instructions and this example PR
  • Is this free of any warnings or errors in the RST?
  • Is this free of spelling errors?
  • Is this free of grammatical errors?
  • Is this free of staging / rendering issues?
  • Are all the links working?

EXTERNAL REVIEW REQUIREMENTS

What's expected of an external reviewer?

@netlify
Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for docs-cluster-to-cluster-sync ready!

Name Link
🔨 Latest commit eb5d954
🔍 Latest deploy log https://app.netlify.com/sites/docs-cluster-to-cluster-sync/deploys/67238fcc4c7ce3000847b229
😎 Deploy Preview https://deploy-preview-457--docs-cluster-to-cluster-sync.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kennethdyer kennethdyer self-requested a review October 30, 2024 17:09
Copy link
Collaborator

@kennethdyer kennethdyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ltran-mdb2, I left a comment for you.


``mongosync`` does not sync source cluster indexes that use a `rolling
index build
<https://www.mongodb.com/docs/manual/tutorial/build-indexes-on-replica-sets/>`_.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The :ref: role can find targets on other repos, so we should use that.

If we rename the server file or delete it, this link won't generate an error until the user 404's. A :ref: will follow moves and start throwing build errors if we remove the file.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

Copy link
Collaborator

@kennethdyer kennethdyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@ajayvijayakumar123 ajayvijayakumar123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a suggestion!

Rolling Index Builds
--------------------

``mongosync`` does not sync source cluster indexes that use a
Copy link
Collaborator

@ajayvijayakumar123 ajayvijayakumar123 Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to make it clear that rolling index builds are not supported during the migration. Mongosync does support indexes that were built via a rolling index build before the migration started.

So instead of saying "If your source cluster has an index with a rolling build ..." I think we could say "instead of building indexes in a rolling fashion during the migration, use one of the following options ... "

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Collaborator

@ajayvijayakumar123 ajayvijayakumar123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ltran-mdb2 ltran-mdb2 merged commit 8fe6397 into mongodb:master Oct 31, 2024
4 checks passed
ltran-mdb2 added a commit to ltran-mdb2/docs-cluster-to-cluster-sync that referenced this pull request Oct 31, 2024
* DOCSP-44876-rolling-index-limitation

* DOCSP-44876-rolling-index-limitation

* DOCSP-44876-rolling-index-limitation

* DOCSP-44876 copy edit

* DOCSP-44876 copy edit

* DOCSP-44876 tech edit
ltran-mdb2 added a commit to ltran-mdb2/docs-cluster-to-cluster-sync that referenced this pull request Oct 31, 2024
* DOCSP-44876-rolling-index-limitation

* DOCSP-44876-rolling-index-limitation

* DOCSP-44876-rolling-index-limitation

* DOCSP-44876 copy edit

* DOCSP-44876 copy edit

* DOCSP-44876 tech edit
ltran-mdb2 added a commit that referenced this pull request Oct 31, 2024
* DOCSP-44876-rolling-index-limitation

* DOCSP-44876-rolling-index-limitation

* DOCSP-44876-rolling-index-limitation

* DOCSP-44876 copy edit

* DOCSP-44876 copy edit

* DOCSP-44876 tech edit
ltran-mdb2 added a commit that referenced this pull request Oct 31, 2024
* DOCSP-44876-rolling-index-limitation

* DOCSP-44876-rolling-index-limitation

* DOCSP-44876-rolling-index-limitation

* DOCSP-44876 copy edit

* DOCSP-44876 copy edit

* DOCSP-44876 tech edit
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants