-
Notifications
You must be signed in to change notification settings - Fork 39
DOCSP-44876-rolling-index-limitation #457
Conversation
✅ Deploy Preview for docs-cluster-to-cluster-sync ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kennethdyer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ltran-mdb2, I left a comment for you.
source/reference/limitations.txt
Outdated
|
|
||
| ``mongosync`` does not sync source cluster indexes that use a `rolling | ||
| index build | ||
| <https://www.mongodb.com/docs/manual/tutorial/build-indexes-on-replica-sets/>`_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The :ref: role can find targets on other repos, so we should use that.
If we rename the server file or delete it, this link won't generate an error until the user 404's. A :ref: will follow moves and start throwing build errors if we remove the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
kennethdyer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ajayvijayakumar123
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a suggestion!
source/reference/limitations.txt
Outdated
| Rolling Index Builds | ||
| -------------------- | ||
|
|
||
| ``mongosync`` does not sync source cluster indexes that use a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want to make it clear that rolling index builds are not supported during the migration. Mongosync does support indexes that were built via a rolling index build before the migration started.
So instead of saying "If your source cluster has an index with a rolling build ..." I think we could say "instead of building indexes in a rolling fashion during the migration, use one of the following options ... "
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
ajayvijayakumar123
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* DOCSP-44876-rolling-index-limitation * DOCSP-44876-rolling-index-limitation * DOCSP-44876-rolling-index-limitation * DOCSP-44876 copy edit * DOCSP-44876 copy edit * DOCSP-44876 tech edit
* DOCSP-44876-rolling-index-limitation * DOCSP-44876-rolling-index-limitation * DOCSP-44876-rolling-index-limitation * DOCSP-44876 copy edit * DOCSP-44876 copy edit * DOCSP-44876 tech edit
DESCRIPTION
Adds rolling index limitation
STAGING
https://deploy-preview-457--docs-cluster-to-cluster-sync.netlify.app/reference/limitations/#rolling-index-builds
JIRA
https://jira.mongodb.org/browse/DOCSP-44876
SELF-REVIEW CHECKLIST
See the taxonomy tagging instructions and this example PR
EXTERNAL REVIEW REQUIREMENTS
What's expected of an external reviewer?