Skip to content

Conversation

@jordan-smith721
Copy link
Contributor

@jordan-smith721 jordan-smith721 commented May 14, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCS-17017
Staging - https://deploy-preview-1007--docs-ecosystem.netlify.app/motor/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

@netlify
Copy link

netlify bot commented May 14, 2025

Deploy Preview for docs-ecosystem ready!

Name Link
🔨 Latest commit 72307f3
🔍 Latest deploy log https://app.netlify.com/projects/docs-ecosystem/deploys/6824fa9e053ba9000872a2f8
😎 Deploy Preview https://deploy-preview-1007--docs-ecosystem.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@rachel-mack rachel-mack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion:

snooty.toml Outdated
Comment on lines 28 to 30
Motor has been sunset in favor of the PyMongo Async API in the PyMongo driver. \
Motor will be deprecated one year after the production release of the PyMongo Async API. \
No further bug fixes will be released after May 14th, 2026, with the exception of critical bug fixes, which will be released until May 14th, 2027. \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be more susinct:

Suggested change
Motor has been sunset in favor of the PyMongo Async API in the PyMongo driver. \
Motor will be deprecated one year after the production release of the PyMongo Async API. \
No further bug fixes will be released after May 14th, 2026, with the exception of critical bug fixes, which will be released until May 14th, 2027. \
Motor has been replaced by the PyMongo Async API, and will be deprecated on May 14th, 2026.\
No further bug fixes will be released after May 14th, 2026, with the exception of critical bug fixes, which will be released until May 14th, 2027. \

I'm not sure how much control you have over formatting, but if possible, there should be a line break at the end of this section.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, but I can't get the banner to add any new lines

@jordan-smith721 jordan-smith721 requested a review from R-shubham May 14, 2025 19:32
Copy link

@R-shubham R-shubham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment, feel free to merge once addressed.

snooty.toml Outdated
targets = ["motor.txt"]
variant = "warning"
value = """
Motor has been sunset in favor of the PyMongo Async API in the PyMongo driver. \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it make sense to add something like this here? -> As of 14th May, 2025 Motor has been sunset in favour of the GA release of Async API in PyMongo. New features will no longer be added to Motor.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the wording here to integrate this and rephrase a bit

@jordan-smith721 jordan-smith721 merged commit 6dce3a5 into mongodb:master May 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants