-
Notifications
You must be signed in to change notification settings - Fork 301
Add deprecation banner to Motor docs #1007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deprecation banner to Motor docs #1007
Conversation
✅ Deploy Preview for docs-ecosystem ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
rachel-mack
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion:
snooty.toml
Outdated
| Motor has been sunset in favor of the PyMongo Async API in the PyMongo driver. \ | ||
| Motor will be deprecated one year after the production release of the PyMongo Async API. \ | ||
| No further bug fixes will be released after May 14th, 2026, with the exception of critical bug fixes, which will be released until May 14th, 2027. \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be more susinct:
| Motor has been sunset in favor of the PyMongo Async API in the PyMongo driver. \ | |
| Motor will be deprecated one year after the production release of the PyMongo Async API. \ | |
| No further bug fixes will be released after May 14th, 2026, with the exception of critical bug fixes, which will be released until May 14th, 2027. \ | |
| Motor has been replaced by the PyMongo Async API, and will be deprecated on May 14th, 2026.\ | |
| No further bug fixes will be released after May 14th, 2026, with the exception of critical bug fixes, which will be released until May 14th, 2027. \ |
I'm not sure how much control you have over formatting, but if possible, there should be a line break at the end of this section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, but I can't get the banner to add any new lines
R-shubham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment, feel free to merge once addressed.
snooty.toml
Outdated
| targets = ["motor.txt"] | ||
| variant = "warning" | ||
| value = """ | ||
| Motor has been sunset in favor of the PyMongo Async API in the PyMongo driver. \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it make sense to add something like this here? -> As of 14th May, 2025 Motor has been sunset in favour of the GA release of Async API in PyMongo. New features will no longer be added to Motor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the wording here to integrate this and rephrase a bit
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCS-17017
Staging - https://deploy-preview-1007--docs-ecosystem.netlify.app/motor/
Self-Review Checklist