Skip to content

Conversation

rustagir
Copy link
Contributor

@rustagir rustagir commented Sep 23, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-42731
Staging - https://deploy-preview-46--docs-mongoid.netlify.app/quick-start/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Sep 23, 2024

Deploy Preview for docs-mongoid ready!

Name Link
🔨 Latest commit cfa5ff6
🔍 Latest deploy log https://app.netlify.com/sites/docs-mongoid/deploys/66f466f5006757000891938d
😎 Deploy Preview https://deploy-preview-46--docs-mongoid.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rustagir rustagir changed the base branch from master to standardized September 23, 2024 20:21
Copy link
Contributor

@norareidy norareidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM + a couple suggestions

source/index.txt Outdated
Comment on lines 9 to 10
``rails``-like tooling, the `railsmdb
<https://github.com/mongodb/mongoid-railsmdb>`_ utility can be used.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: change to active voice

Suggested change
``rails``-like tooling, the `railsmdb
<https://github.com/mongodb/mongoid-railsmdb>`_ utility can be used.
``rails``-like tooling, you can use the `railsmdb
<https://github.com/mongodb/mongoid-railsmdb>`_.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, just left this as placeholder content until the index ticket


This guide shows you how to use {+odm+} in a new web application,
connect to a MongoDB cluster hosted on MongoDB Atlas, and perform
read and write operations on the data.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: since "the data" is a little vague:

Suggested change
read and write operations on the data.
read and write operations on the data in your cluster.

@rustagir rustagir merged commit 25eebe4 into mongodb:standardized Sep 25, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants