DOCSP-44821: specify a query pt 2 #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-mongoid ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…OCSP-44821-specify-query-2
mongoKart
requested changes
Nov 7, 2024
mongoKart
approved these changes
Nov 14, 2024
Comment on lines
561
to
562
| The ``find()`` method converts the ID that you pass to the | ||
| data type declared for the ``_id`` field in the model. By |
There was a problem hiding this comment.
What do you think about this?
Suggested change
| The ``find()`` method converts the ID that you pass to the | |
| data type declared for the ``_id`` field in the model. By | |
| When you pass an ID to the ``find()`` method, the method converts it | |
| to the data type declared for the ``_id`` field in the model. By |
Comment on lines
561
to
563
| The ``find()`` method performs the type conversion of the argument that | ||
| you pass to the type declared for the ``_id`` field in the model. By | ||
| default, the ``_id`` field is defined as a ``BSON::ObjectId`` type. |
There was a problem hiding this comment.
This was still a little confusing because my brain wants to read "pass to" as a verbal phrase instead of verb + preposition, if that makes sense. What about:
"When you pass an ID to the find() method, it converts the ID to the data type..."
|
|
||
| You can use the ``find_or_create_by()`` method to retrieve documents | ||
| based on the provided criteria. If no documents are found, it creates | ||
| and returns a newly persisted one. |
There was a problem hiding this comment.
Sorry, I meant the idea of persisting--that one's new to me.
Comment on lines
643
to
645
| new one, without persisting it to MongoDB. The syntax for | ||
| ``find_or_initialize_by()`` is the same for the ``find_or_create_by()`` | ||
| method. |
There was a problem hiding this comment.
I think you need an "as" in here: "The syntax for X is the same as [the syntax] for Y."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-44821
Staging - Starts at https://deploy-preview-61--docs-mongoid.netlify.app/interact-data/specify-query/#element-match
Self-Review Checklist