Skip to content

DOCSP-44946 TOC Relabel #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 21, 2024
Merged

DOCSP-44946 TOC Relabel #62

merged 3 commits into from
Nov 21, 2024

Conversation

lindseymoore
Copy link
Contributor

@lindseymoore lindseymoore commented Nov 9, 2024 •
edited
Loading

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-44946
Staging - https://deploy-preview-62--docs-mongoid.netlify.app/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

@netlify Netlify
Copy link

netlify bot commented Nov 9, 2024 •
edited
Loading

✅ Deploy Preview for docs-mongoid ready!

Name Link
🔨 Latest commit 8502027
🔍 Latest deploy log https://app.netlify.com/sites/docs-mongoid/deploys/673f642065c7c00008f80fe3
😎 Deploy Preview https://deploy-preview-62--docs-mongoid.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mongoKart
mongoKart approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm w/ suggestions

sarahemlin
sarahemlin requested changes Nov 21, 2024
View reviewed changes
source/tutorials.txt
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can leave off "Getting Started" and just use the product name for these.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about something like 'Sinatra App'? Just so readers have a hint of what they're getting into and might be more attracted

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left with just the product name, but let me know if including 'App' makes sense to you.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My feeling is that if you're using this Driver, you probably know your options and don't think this is about Frank Sinatra. I misread your message and approved the PR before reading that you wanted to put 'App' in. Sorry!!

@lindseymoore lindseymoore merged commit 884292f into mongodb:master Nov 21, 2024
4 of 6 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 21, 2024
@lindseymoore @github-actions
DOCSP-44946 TOC Relabel (#62)
71d28ef 
* DOCSP-44946 TOC Relabel

* Mike's suggestion

* sarah's suggestion

(cherry picked from commit 884292f)
@github-actions github-actions bot mentioned this pull request Nov 21, 2024
Merged
lindseymoore added a commit that referenced this pull request Nov 21, 2024
@github-actions @lindseymoore
DOCSP-44946 TOC Relabel (#62) (#70)
b3a8b8e 
* DOCSP-44946 TOC Relabel

* Mike's suggestion

* sarah's suggestion

(cherry picked from commit 884292f)

Co-authored-by: lindseymoore <71525840+lindseymoore@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarahemlin sarahemlin sarahemlin approved these changes

@mongoKart mongoKart mongoKart approved these changes

Assignees

No one assigned

Labels

backport 9.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lindseymoore @sarahemlin @mongoKart