DOCSP-42034-allow-custom-polymorphic-types #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-mongoid ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jordan-smith721
requested changes
Dec 16, 2024
Contributor
jordan-smith721
left a comment
jordan-smith721
left a comment
There was a problem hiding this comment.
Nice work on this! Left some suggestions for clarity and some style guide fixes. Happy to discuss any of the comments if needed as well
jordan-smith721
approved these changes
Dec 16, 2024
Contributor
jordan-smith721
left a comment
jordan-smith721
left a comment
There was a problem hiding this comment.
LGTM w/ a few more suggestions!
jamis
approved these changes
Dec 16, 2024
gmiller-mdb
added a commit
that referenced
this pull request
Dec 17, 2024
* DOCSP-42034-allow-custom-polymorphic-types * updated copy * copy edits * copy * copy fix (cherry picked from commit 7abc88b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-42034
Staging - https://deploy-preview-78--docs-mongoid.netlify.app/reference/associations/#polymorphism
Self-Review Checklist