Skip to content

Conversation

@norareidy
Copy link
Collaborator

@norareidy norareidy commented Aug 2, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-42093
Staging - https://preview-mongodbnorareidy.gatsbyjs.io/rust/DOCSP-42093-8.0-compat/compatibility/

See the Slack thread for more context.

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link
Collaborator

@shuangela shuangela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with one confusion

- ✓
- ✓
-
* - 3.0 [#2.5-onwards-limitation]_
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: Based on the slack convo, I'm a little confused why only 2.6 fully supports version 7.0 while newer versions don't? I assumed the engineer meant 2.6 and beyond, but could you clarify that? Everything else looks good

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right - this should be the versions since 2.6! I'll get a tech review just to confirm

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I expect Rust driver versions >=2.6 support server 7.0.

@norareidy norareidy requested a review from shuangela August 5, 2024 20:21
Copy link
Collaborator

@shuangela shuangela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@norareidy norareidy requested a review from kevinAlbs August 6, 2024 15:57
- ✓
- ✓
-
* - 3.0 [#2.5-onwards-limitation]_
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I expect Rust driver versions >=2.6 support server 7.0.

@norareidy norareidy merged commit 417f55d into mongodb:master Aug 6, 2024
@norareidy norareidy deleted the DOCSP-42093-8.0-compat branch August 6, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants