Skip to content

Conversation

@stephmarie17
Copy link
Collaborator

@stephmarie17 stephmarie17 commented Nov 21, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-45153
Staging - https://deploy-preview-152--docs-rust.netlify.app/fundamentals/enterprise-auth/#mongodb-oidc

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

@netlify
Copy link

netlify bot commented Nov 21, 2024

Deploy Preview for docs-rust ready!

Name Link
🔨 Latest commit 03309a4
🔍 Latest deploy log https://app.netlify.com/sites/docs-rust/deploys/67521afcda13bf00080208ee
😎 Deploy Preview https://deploy-preview-152--docs-rust.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stephmarie17 stephmarie17 marked this pull request as ready for review November 21, 2024 20:20
Copy link
Collaborator

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few small things, but great job overall!

Copy link
Collaborator

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@isabelatkinson isabelatkinson self-requested a review November 26, 2024 21:14
Copy link
Collaborator

@isabelatkinson isabelatkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! I have a few more small suggestions but I'll leave it up to you whether to add the changes 🙂

@stephmarie17 stephmarie17 merged commit 6700bfd into mongodb:master Dec 5, 2024
5 checks passed
stephmarie17 added a commit that referenced this pull request Dec 5, 2024
(cherry picked from commit 6700bfd)
stephmarie17 added a commit that referenced this pull request Dec 5, 2024
(cherry picked from commit 6700bfd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants