-
Notifications
You must be signed in to change notification settings - Fork 20
DOCSP-44969: Modify insert usage examples #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-44969: Modify insert usage examples #154
Conversation
✅ Deploy Preview for docs-rust ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
stephmarie17
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a small fix ✅
source/usage-examples/insertOne.txt
Outdated
|
|
||
| .. input:: /includes/usage-examples/code-snippets/insert-one-async.rs | ||
| :language: rust | ||
| :emphasize-lines: 19, 35 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[n] In the deploy preview, I don't see the expected lines highlighted so these may need to be adjusted.
source/usage-examples/insertOne.txt
Outdated
|
|
||
| .. input:: /includes/usage-examples/code-snippets/insert-one-sync.rs | ||
| :language: rust | ||
| :emphasize-lines: 18, 34 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above.
abr-egn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
(cherry picked from commit 6d8f6ce)
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-44969
Staging -
https://deploy-preview-154--docs-rust.netlify.app/usage-examples/insertOne/
https://deploy-preview-154--docs-rust.netlify.app/usage-examples/insertMany/
Self-Review Checklist