Skip to content

Conversation

@norareidy
Copy link
Collaborator

@norareidy norareidy commented Dec 4, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-44969
Staging -
https://deploy-preview-154--docs-rust.netlify.app/usage-examples/insertOne/
https://deploy-preview-154--docs-rust.netlify.app/usage-examples/insertMany/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

@netlify
Copy link

netlify bot commented Dec 4, 2024

Deploy Preview for docs-rust ready!

Name Link
🔨 Latest commit 3e755de
🔍 Latest deploy log https://app.netlify.com/sites/docs-rust/deploys/67509ddbf822f90008ed1385
😎 Deploy Preview https://deploy-preview-154--docs-rust.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@stephmarie17 stephmarie17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a small fix ✅


.. input:: /includes/usage-examples/code-snippets/insert-one-async.rs
:language: rust
:emphasize-lines: 19, 35
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[n] In the deploy preview, I don't see the expected lines highlighted so these may need to be adjusted.


.. input:: /includes/usage-examples/code-snippets/insert-one-sync.rs
:language: rust
:emphasize-lines: 18, 34
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

Copy link
Collaborator

@abr-egn abr-egn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@norareidy norareidy merged commit 6d8f6ce into mongodb:master Dec 5, 2024
5 checks passed
@norareidy norareidy deleted the DOCSP-44969-insert-usage-exs branch December 5, 2024 15:04
norareidy added a commit that referenced this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants