DOCSP-44971: Count & distinct usage ex updates #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-rust ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mongoKart
approved these changes
Feb 6, 2025
Collaborator
mongoKart
left a comment
mongoKart
left a comment
There was a problem hiding this comment.
LGTM w/ 1 question/suggestion
source/usage-examples/count.txt
Outdated
| the collection's data, replace the ``<T>`` type parameter on the highlighted | ||
| line with one of the following values: | ||
|
|
||
| - ``<Document>``: Accesses collection documents as BSON documents |
Collaborator
There was a problem hiding this comment.
q: is it more accurate to say 'Represents' or something instead of 'Accesses'? since the user is presumably the one doing the accessing
Collaborator
Author
There was a problem hiding this comment.
Good point, I think "represents" makes more sense
norareidy
requested review from
a team and
isabelatkinson
and removed request for
a team
isabelatkinson
approved these changes
Feb 6, 2025
norareidy
added a commit
that referenced
this pull request
Feb 7, 2025
(cherry picked from commit c2614e6)
norareidy
added a commit
that referenced
this pull request
Feb 7, 2025
(cherry picked from commit c2614e6)
norareidy
added a commit
that referenced
this pull request
Feb 7, 2025
(cherry picked from commit c2614e6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-44971
Staging - https://deploy-preview-163--docs-rust.netlify.app/usage-examples/count/
https://deploy-preview-163--docs-rust.netlify.app/usage-examples/distinct/
Self-Review Checklist