-
Notifications
You must be signed in to change notification settings - Fork 5
Final cleanup pass #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, with one note that I see a comment we can probably delete from the movies.py file (at line 81, starting with the sentence "This function was made with the assumption that the UI will have fields for plot,fullplot, directors, writers, and cast to search on")
Other than that, this cleanup looks good!
| - [Load sample data](https://www.mongodb.com/docs/atlas/sample-data/) | ||
| - **pip** for Python package management | ||
| - **Voyage AI API key** (For MongoDB Vector Search) | ||
| - [Get a Voyage AI API key](https://www.voyageai.com/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another note: do we need them to install uvicorn from pip, or is that included in the requirements file/included if we add fastapi to requirements?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question! I didn't do anything special to install uvicorn, so I assume it came along with something that's already in requirements (maybe FastAPI). We can research that as a fast follow.
Removes unused code, makes minor tweaks to READMEs and ensures the frontend and backend run together.
I'm having some issues with Java which I will try to diagnose separately. I don't want to hold this up.