Skip to content

Conversation

@dacharyc
Copy link
Collaborator

@dacharyc dacharyc commented Nov 7, 2025

Removes unused code, makes minor tweaks to READMEs and ensures the frontend and backend run together.

I'm having some issues with Java which I will try to diagnose separately. I don't want to hold this up.

Copy link
Collaborator

@shuangela shuangela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, with one note that I see a comment we can probably delete from the movies.py file (at line 81, starting with the sentence "This function was made with the assumption that the UI will have fields for plot,fullplot, directors, writers, and cast to search on")

Other than that, this cleanup looks good!

- [Load sample data](https://www.mongodb.com/docs/atlas/sample-data/)
- **pip** for Python package management
- **Voyage AI API key** (For MongoDB Vector Search)
- [Get a Voyage AI API key](https://www.voyageai.com/)
Copy link
Collaborator

@shuangela shuangela Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another note: do we need them to install uvicorn from pip, or is that included in the requirements file/included if we add fastapi to requirements?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question! I didn't do anything special to install uvicorn, so I assume it came along with something that's already in requirements (maybe FastAPI). We can research that as a fast follow.

@dacharyc dacharyc merged commit bf1d310 into mongodb:development Nov 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants