Skip to content

chore: Uses go.mod version in Github Action instead of a specific version #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2023
Merged

chore: Uses go.mod version in Github Action instead of a specific version #520

merged 1 commit into from
Oct 31, 2023

Conversation

lantoli
Copy link
Member

@lantoli lantoli commented Oct 31, 2023

Description

Uses go.mod version in Github Action instead of a specific version

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Required Checklist:

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

@lantoli lantoli requested a review from a team as a code owner October 31, 2023 15:54
@lantoli lantoli requested review from gssbzn and wtrocki October 31, 2023 16:13
gssbzn
gssbzn reviewed Oct 31, 2023
View reviewed changes
Copy link
Contributor

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

based on this comemnt #519 (comment) should we update that one as well

@lantoli
Copy link
Member Author

lantoli commented Oct 31, 2023

based on this comemnt #519 (comment) should we update that one as well

@gssbzn not sure what you say that needs to be updated

@gssbzn
Copy link
Contributor

gssbzn commented Oct 31, 2023

not sure what you say that needs to be updated

Sorry I just saw it was updated already never mind

@lantoli lantoli merged commit 4cc6f1e into master Oct 31, 2023
@lantoli lantoli deleted the go_mod branch October 31, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wtrocki wtrocki Awaiting requested review from wtrocki

1 more reviewer

@gssbzn gssbzn gssbzn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lantoli @gssbzn