CLOUDP-60028: Implement index creation in atlas client #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@andreaangiolillo fixed some copy/pasta |
3 tasks
Contributor
Author
|
@themantissa ready for you and your team |
themantissa
previously approved these changes
Apr 7, 2020
Collaborator
themantissa
left a comment
themantissa
left a comment
There was a problem hiding this comment.
Just a note about a confusing comment but otherwise LGTM. Will add DoU reviewers.
mongodbatlas/indexes.go
Outdated
|
|
||
| var _ IndexesService = &IndexesServiceOp{} | ||
|
|
||
| // IndexConfiguration represents current value of the metric that triggered the alert. Only present for alerts of type HOST_METRIC. |
Collaborator
There was a problem hiding this comment.
Just a nit but this comment is confusing - this has nothing to do with metrics, yes?
Contributor
Author
There was a problem hiding this comment.
oops, probably copy/pasta, I'll fix this
Collaborator
|
@marinsalinas @PacoDw @coderGo93 - can one of you give a sanity check review? Sadly it's unlikely we'll use this w/ Terraform as the post with no response won't work well with the Terraform way. |
gssbzn
dismissed stale reviews from PacoDw, themantissa, and andreaangiolillo
via
cf16fc0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.